Skip to content

Add ListClients and DeleteClient operations #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Jan 12, 2021

Also adds the new response status code
Fix #93
Fix #94

@hug-dev hug-dev requested a review from ionut-arm January 12, 2021 14:55
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, only one question (maybe I didn't see it?): don't you need another method on Opcode - is_admin?

@hug-dev
Copy link
Member Author

hug-dev commented Jan 12, 2021

Changes look good, only one question (maybe I didn't see it?): don't you need another method on Opcode - is_admin?

Oh that's a good idea. I was thinking of adding the check into every case that needs it in the back end handler but that seems more optimal to do it once for all, will add.

Also adds the new response status code

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev hug-dev merged commit c8a5954 into parallaxsecond:master Jan 12, 2021
@hug-dev hug-dev deleted the list-clients branch January 12, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ListClients and DeleteClient structures Add a new ResponseStatus for admin operations
2 participants