Add ListKeys operation #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2020 11:27
Signed-off-by: Joe Ellis <[email protected]>
Signed-off-by: Joe Ellis <[email protected]>
joechrisellis
force-pushed
the
add-list-keys
branch
2 times, most recently
from
1f7e841 to
7b40757
Compare
ionut-arm
reviewed
Oct 7, 2020
src/operations/list_keys.rs
Outdated
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct KeyInfo { | ||
| /// The ID of the associated provider. | ||
| pub provider_id: u32, |
joechrisellis
force-pushed
the
add-list-keys
branch
2 times, most recently
from
11323fb to
092595e
Compare
added 2 commits
October 7, 2020 13:09
Signed-off-by: Joe Ellis <[email protected]>
Signed-off-by: Joe Ellis <[email protected]>
joechrisellis
force-pushed
the
add-list-keys
branch
from
092595e to
c0d5229
Compare
ionut-arm
approved these changes
Oct 7, 2020
Comment on lines
+10
to
+18
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct KeyInfo { | ||
| /// The ID of the associated provider. | ||
| pub provider_id: ProviderID, | ||
| /// The name of the key. | ||
| pub name: String, | ||
| /// The key attributes. | ||
| pub attributes: Attributes, | ||
| } |
There was a problem hiding this comment.
Does Attributes have Display implemented? If so, it might be worth implementing it for this one as well, might make the job in parsec-tool easier 😄
There was a problem hiding this comment.
Ah, great spot -- but unfortunately it does not have Display implemented. We can add this in another PR. 😄
hug-dev
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.