-
Notifications
You must be signed in to change notification settings - Fork 20
Add a JWT-SVID authentication method #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using this method, the client will fetch its JWT-SVID and send it in the authentication field. The socket endpoint is found through the SPIFFE_ENDPOINT_SOCKET environment variable. Signed-off-by: Hugues de Valon <[email protected]>
This won't work until the changes are pushed in some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good overall, just a few minor comments
Signed-off-by: Hugues de Valon <[email protected]>
Addressed comment in a new commit for easier review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Used this branch to make it compile now. Added a feature as was agreed in the community meeting. |
225810f
to
7fa0a9a
Compare
Also add a feature for the SPIFFE authenticator, activated by default. Signed-off-by: Hugues de Valon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Using this method, the client will fetch its JWT-SVID and send it in the
authentication field.
The socket endpoint is found through the SPIFFE_ENDPOINT_SOCKET
environment variable.