Add ListKeys support #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: won't pass CI because this is pending a version bump to |
hug-dev
reviewed
Oct 8, 2020
joechrisellis
force-pushed
the
add-list-keys
branch
2 times, most recently
from
b0af408 to
b7bcc3f
Compare
hug-dev
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Thanks!
I would personally be ok to merge this, even if it contains a patch. We can't publish a crates-io version with a patch in it anyway (so no mistake is possible) and that leaves us some room to continue development until the next version without keeping this PR up.
@ionut-arm What do you think?
Cargo.toml
Outdated
| @@ -26,3 +26,6 @@ mockstream = "0.0.3" | |||
| [features] | |||
| testing = ["parsec-interface/testing", "no-fs-permission-check"] | |||
| no-fs-permission-check = [] | |||
|
|
|||
| [patch.crates-io] | |||
| parsec-interface = { git = "https://github.com/joechrisellis/parsec-interface-rs.git", branch = "add-list-keys" } | |||
There was a problem hiding this comment.
This should work as everything should be merged in the interface 😃
-parsec-interface = { git = "https://github.com/joechrisellis/parsec-interface-rs.git", branch = "add-list-keys" }
+parsec-interface = { git = "https://github.com/parallaxsecond/parsec-interface-rs" }
joechrisellis
force-pushed
the
add-list-keys
branch
2 times, most recently
from
4bfd365 to
b3d3b4e
Compare
ionut-arm
reviewed
Oct 12, 2020
Cargo.toml
Outdated
| @@ -26,3 +26,6 @@ mockstream = "0.0.3" | |||
| [features] | |||
| testing = ["parsec-interface/testing", "no-fs-permission-check"] | |||
| no-fs-permission-check = [] | |||
|
|
|||
| [patch.crates-io] | |||
| parsec-interface = { git = "https://github.com/parallaxsecond/parsec-interface-rs.git" } | |||
There was a problem hiding this comment.
Is it possible to scope this down to a particular commit? Otherwise we could end up making breaking changes.
added 3 commits
October 12, 2020 11:44
Patched dependency to use joechrisellis/parsec-interface-rs. Signed-off-by: Joe Ellis <[email protected]>
Signed-off-by: Joe Ellis <[email protected]>
Signed-off-by: Joe Ellis <[email protected]>
joechrisellis
force-pushed
the
add-list-keys
branch
from
b3d3b4e to
d8d630b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust client support for the
ListKeysoperation.