Skip to content

async class method not highlighted #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arch-mage opened this issue Jun 22, 2016 · 5 comments
Closed

async class method not highlighted #506

arch-mage opened this issue Jun 22, 2016 · 5 comments

Comments

@arch-mage
Copy link

This class

class ClassName {
  async methodName(arg1) {
  }
}

should have async keyword highlighted as jsAsyncKeyword. But it is not. It just have jsClassBlock.

If I'm correct adding jsAsyncKeyword to this line should fix this, because it works
for me.

@amadeus
Copy link
Collaborator

amadeus commented Jun 22, 2016

Thanks for posting this issue! I'll have a fix in 'develop' shortly!

amadeus added a commit that referenced this issue Jun 22, 2016
It's an ES7 feature, fixes #506
@arch-mage
Copy link
Author

@amadeus Sorry, I didn't notice this before. This issue is applied on Object too. So, this:

const obj = {
  async method() {
    await asyncFunc();
  }
};

Just in case you didn't notice.

@amadeus
Copy link
Collaborator

amadeus commented Jun 22, 2016

I see, do you have some documentation for this ES7 feature somewhere that I could reference?

@arch-mage
Copy link
Author

Tracked down on babel, and I found this spec about async and await.

@amadeus
Copy link
Collaborator

amadeus commented Jun 22, 2016

I added it to objects in #507 as well.

amadeus added a commit that referenced this issue Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants