Suggestion: Could it follow the Standard style ?

[yormi]

I have a couple of issues with indentation.

Using the ...variable (spread operator) in an array or object on multiline for instance.

I'm not sure what is the style you guys want to follow with indentation. I was thinking that Standard would be a wise choice.

At the same time, is the spread operator thing an issue that you plan to work on ?

EDIT: I almost forget to thank you for the work. Thanks !

[bounceme]

can you give an example? an example for what you mean with the standard recommendation would be helpful

[bounceme]

guessing by my results with this file as a measure https://github.com/feross/bittorrent-dht/blob/master/client.js we have support already for 'standard' js

[yormi]

I had few tiny problems but I updated lately and since then I think the indentation with ES6 spread operator is my only problem (no instances of this in the measure file):

let example = [
  ...someObject,
  somethingElse
]

Instead of giving the above, the indentation change it for:

let example = [
  ...someObject,
somethingElse
]

And, as you probably understood, this does not follow standardjs convention. MOreover, when somethingElse is an object literal instead of a variable, it makes it very not fun at all to read ;)

[bounceme]

most operator edge cases are caused by mixing operator first style with operator end style.maybe the spread operator is a special case though. moving the comma to the start of line three should fix your immediate issue

[yormi]

Ok thanks for the work around but I think I prefer just fix it by hand and wait for the fix. If I may ask, do you plan to fix it ? :)

[bounceme]

i already have haha

[bounceme]

#462

[yormi]

My hero ! haha

Yep it seems to work ! Thank you !

Should I close the issue or wait that the PR is merge ?

[bounceme]

i'll merge it to develop, seems to be pretty safe

[yormi]

Perfect !

Thanks again :)

2016-06-04 2:09 GMT+08:00 bounceme notifications@github.com:

i'll merge it to develop, seems to be pretty safe

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#461 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGIEJPEuVVIKD584srvBq8ikChIRpf5Yks5qIG3HgaJpZM4ItQML
.

[yormi]

@bounceme

I have another issue of the same kind with the indentation and Standard style.

let someArray = [
{
  prop: 'Hello World'
}
]

Should be:

let someArray = [
  {
    prop: 'Hello World'
  }
]

If you have a quick fix as know you can do, that would be amazing :)

[bounceme]

lines with only an opening brace,along with multiline comments and switch cases, use vim's c-implemented cindent.

set cinwords+=let
set cino+={1s

works but only when you are inside braces at any level(so if that is your entire file than it won't work)

[bounceme]

actually you can try this, or all three settings together set cino+=f1s

[yormi]

Are you some kind of genius or something !? :P

set cino+=f1s worked perfectly !