Skip to content

Syntax support for ES property initializers #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iansinnott opened this issue May 12, 2016 · 1 comment
Closed

Syntax support for ES property initializers #433

iansinnott opened this issue May 12, 2016 · 1 comment
Assignees

Comments

@iansinnott
Copy link

I'm not sure if this is a bug or simply something that is not yet supported, but it would be awesome to see support for ES class property initializers. They are currently a stage-1 proposal but they make authoring React components much nicer.

I've tried this on both develop and master.

Example code:

export class About extends React.Component {
  static propTypes = {
    children: PropTypes.any,
  }
  render() {
    return (
      <div className={cx('page')}>
        <div className={cx('siteTitle')}>
          <h1>About Page</h1>
        </div>
        <p>Welcome to the about page...</p>
      </div>
    );
  }
}

export class NotFound extends React.Component {
  render() {
    return (
      <div className={cx('page')}>
        <h4>Not found</h4>
      </div>
    );
  }
}

Here's how it's currently being highlighted. I annotated the screenshot with the syntax IDs of the highlighted parts of text:

app_js______dev_js_redux-second-run_client_components__-_vim

Related: #393

@amadeus amadeus self-assigned this May 16, 2016
@amadeus amadeus mentioned this issue Jun 6, 2016
amadeus added a commit that referenced this issue Jun 6, 2016
@amadeus
Copy link
Collaborator

amadeus commented Jun 12, 2016

Should be fixed in develop

@amadeus amadeus closed this as completed Jun 12, 2016
amadeus added a commit that referenced this issue Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants