Skip to content

Conversation

shawnlinxl
Copy link
Contributor

Some companies have self-hosted Github Enterprise instances. It will be great if we can allow people within the organization to edit the documentation through this convenient one-click feature.

@jorisvandenbossche
Copy link
Member

Thanks for your contribution!

Can you add a note about this in the docs here: https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/configuring.html ?

@shawnlinxl
Copy link
Contributor Author

Yes, definitely.

@shawnlinxl
Copy link
Contributor Author

@jorisvandenbossche Sorry, my previous pull request that has been merged actually updated another part of this configuring guide. I am not sure what the correct workflow should be in this case.

I opened another pull request #214 to complete the documentation.

@jorisvandenbossche
Copy link
Member

my previous pull request that has been merged actually updated another part of this configuring guide. I am not sure what the correct workflow should be in this case.

The typical workflow it to merge the latest upstream master in this branch, so this branch is updated with those merged changes, and then you can add the docs here.

@jorisvandenbossche
Copy link
Member

But will merge it now as the two PRs, thanks again!

@jorisvandenbossche jorisvandenbossche merged commit 2bb0a9e into pydata:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants