Skip to content

Conversation

robertdavidwest
Copy link
Contributor

Redefined take_last variable in doc string. Original definition only
made sense for drop_duplicates()

…licated()

Redefined `take_last` variable in doc string. Original definition only
made sense for drop_duplicates()
jorisvandenbossche added a commit that referenced this pull request Jan 7, 2015
…gle_commit

9203 SQUASHED - DOCS: doc string edited pandas/core/frame.duplicated()
@jorisvandenbossche jorisvandenbossche merged commit b62754d into pandas-dev:master Jan 7, 2015
@jorisvandenbossche
Copy link
Member

@robertdavidwest Thanks!

For future reference, it is not needed to create an new branch/new PR when squashing. If you just do

git rebase -i upstream/master

and then squash, you can just push the same branch again (but using --force):

git push --force origin DataFrame_duplicated_docstring_amend

@jorisvandenbossche jorisvandenbossche added this to the 0.16.0 milestone Jan 7, 2015
@robertdavidwest
Copy link
Contributor Author

Thanks Joris. baby steps...

On 7 January 2015 at 11:28, Joris Van den Bossche [email protected]
wrote:

@robertdavidwest https://github.com/robertdavidwest Thanks!

For future reference, it is not needed to create an new branch/new PR when
squashing. If you just do

git rebase -i upstream/master

and then squash, you can just push the same branch again (but using
--force):

git push --force origin DataFrame_duplicated_docstring_amend


Reply to this email directly or view it on GitHub
#9206 (comment).

@jorisvandenbossche
Copy link
Member

No problem! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants