SQL: don't reflect full database GH7396 #7581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielballan @mangecoeur @hayd can someone review this? |
|
I had a look and it all seems sane, but don't have time to actually run it right now :( |
|
OK, merging then. All tests still pass so should be OK. |
jorisvandenbossche
added a commit
that referenced
this pull request
Jul 5, 2014
SQL: don't reflect full database GH7396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7396
For now, let PandasSQLAlchemy not reflect anything by default, and
read_sql_tableprovides its own reflected meta. Had to change some of the other functions to get this working.@danielballan @mangecoeur Can someone review? (it feeled a bit messy)