support axis=None for nanmedian ( issue #7352 ) #7440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added a fix (hopefully) for the rounding errors |
| @@ -118,11 +120,39 @@ def check_results(self, targ, res, axis): | |||
| res = getattr(res, 'values', res) | |||
| if axis != 0 and hasattr(targ, 'shape') and targ.ndim: | |||
| res = np.split(res, [targ.shape[0]], axis=0)[0] | |||
| tm.assert_almost_equal(targ, res) | |||
| try: | |||
There was a problem hiding this comment.
you can just pass check_less_precise=True if its a complex number (or explicty astype before the comparison)
There was a problem hiding this comment.
I tried that, it doesn't fix the problem. It still raises an AssertionError even if they only differ in their 16th digit.
There was a problem hiding this comment.
>>> a=np.array([1+.1111111111111111*1j])
>>> b=np.array([1+.1111111111111112*1j])
>>> tm.assert_almost_equal(a, b, check_less_precise=True)
AssertionError: (1+0.1111111111111111j) != (1+0.1111111111111112j)There was a problem hiding this comment.
compare the real and imag pars separately and then it works correctly. side issue is to patch tm.assert_almost_equal to deal with complex numbers by this method
In [1]: a=np.array([1+.1111111111111111*1j])
In [2]: b=np.array([1+.1111111111111112*1j])
In [4]: tm.assert_almost_equal(a.real, b.real)
Out[4]: True
In [5]: tm.assert_almost_equal(a.imag, b.imag)
Out[5]: True
jreback
added a commit
that referenced
this pull request
Jun 12, 2014
support axis=None for nanmedian ( issue #7352 )
|
thanks! |
|
@toddrjen a bunch of tests failing on windows. I debugged one of them below. If you can debug this would be great. |
|
The problem seems to be that the values are getting converted to a python long instead of a numpy scalar. The workaround is easy, I can either include it in a separate patch or as part of the next one. But could you also try the following code and see what you get? a=np.zeros(11).astype('bool')
b=a.shape[0] - a.sum(0)
type(b)I have tried this on linux, winpython3 x64, and pythonxy and in all of them I get |
|
At least looking at the last error, for nanskew, it doesn't appear that I have touched any of the code in that code path, so this doesn't seem to be a new bug. |
|
All of the errors are related to the changes for |
|
There were no changes to _get_counts. Looking at the blame, it hasn't been touched since 2011. |
|
it wasn't broken before I merged your first PR. |
|
The first version of |
|
ok, its a problem now. pls have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7352, where
nanmediandoes not work whenaxis==None.