Skip to content

changed the pydata-sphinx-theme dependency to the git version #61548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

louisjh14
Copy link

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@datapythonista datapythonista added the Dependencies Required and optional dependencies label Jun 4, 2025
@datapythonista
Copy link
Member

This seems a bad idea. And if you think we should be doing this, please open an issue with the motivation, or at least write a description in the PR, so this can be discussed. But we don't want changes to a sphinx theme breaking our CI, so I don't think we'll get this merged.

@louisjh14
Copy link
Author

This was related to issue #51536. This is my first time, I must off misunderstood what he was looking for.

@datapythonista
Copy link
Member

Thanks for the information. The first line in the template is to provide the issue you are addressing, so we have more context.

I opened that issue, and there is indeed some misunderstanding. I think we are probably using a version that supports the footer now, you'll have to check. But the issue is about simplifying the footer. Maybe we need to upgrade the sphinx theme, but that would be to a specific version.

I can reopen this PR if needed, but probably better to start in a new branch. Juat let me know if you reuse this branch so I can reopen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants