Subplot title count fix + fix for issue introduced in earlier PR #61393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clarification if it matters)
…2/pandas into subplot_label_count_fix
mroeschke
reviewed
May 5, 2025
mroeschke
reviewed
May 5, 2025
mroeschke
reviewed
May 5, 2025
mroeschke
reviewed
May 6, 2025
mroeschke
approved these changes
May 7, 2025
|
Thanks again @eicchen |
xaris96
pushed a commit
to xaris96/pandas
that referenced
this pull request
May 30, 2025
…das-dev#61393) * test case for subplot stacking * Removed overlooked print statement * Updated test to check other subplot in figure * Updated test cases to include more subplot stacking possibilities * removed savefig() left in test cases * Updated test cases to test more arrangements * Completed function fix (order of subplot input does not matter, need clarification if it matters) * appeasing the great pre-commit formatter * Updated whatsnew * Docstring adjustment * Moved self.subplot check to a seperate bool * Added ignore where mypy thinks self.subplots is a bool * Actually addressed mypy typing * Incorperated initial PR comments * Updated missing () after .all * Initial test cases * Addressed more comments on PR * Updated '&' to 'and' * Updated Test cases * Fixed crash when "subplots=True" is used * Title check checks for subplot length if specified * Updated Test cases * Title check checks for subplot length if specified * Updated test name * Removed extra '_' in test name * Fixed issue where expected_total_height returns as a df instead of a series * Updated change notes * Addressed mypy error * Addresed PR comments * Changed exception message raised and updated test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Adds a check for length of subplots as an alternative to the default title check and produces an alternative error message if number of subplots does not match titles produced.
Additionally, includes fix for issues introduced during PR: #61340 and mentioned in #61018