-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: Remove ASAN job #57886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI: Remove ASAN job #57886
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
31ad407
Try removing subprocess call in conftest
WillAyd 7f50043
empty bytes
WillAyd 2f9316d
try non-editable
WillAyd 08213d3
Revert "try non-editable"
WillAyd e4ea69e
Revert "empty bytes"
WillAyd 261d234
Revert "Try removing subprocess call in conftest"
WillAyd 398e19f
Remove ASAN job
WillAyd 1aecf56
Merge remote-tracking branch 'upstream/main' into try-asan-debug
WillAyd 9b8dd85
revert more
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,14 +68,6 @@ jobs: | |
- name: "Pyarrow Nightly" | ||
env_file: actions-311-pyarrownightly.yaml | ||
pattern: "not slow and not network and not single_cpu" | ||
- name: "ASAN / UBSAN" | ||
env_file: actions-311-sanitizers.yaml | ||
pattern: "not slow and not network and not single_cpu and not skip_ubsan" | ||
asan_options: "ASAN_OPTIONS=detect_leaks=0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you remove these extra GHA args in this file/other files as well that are only used for this job too? |
||
preload: LD_PRELOAD=$(gcc -print-file-name=libasan.so) | ||
meson_args: --config-settings=setup-args="-Db_sanitize=address,undefined" | ||
cflags_adds: -fno-sanitize-recover=all | ||
pytest_workers: -1 # disable pytest-xdist as it swallows stderr from ASAN | ||
fail-fast: false | ||
name: ${{ matrix.name || format('ubuntu-latest {0}', matrix.env_file) }} | ||
env: | ||
|
@@ -161,18 +153,12 @@ jobs: | |
- name: Test (not single_cpu) | ||
uses: ./.github/actions/run-tests | ||
if: ${{ matrix.name != 'Pypy' }} | ||
with: | ||
preload: ${{ matrix.preload }} | ||
asan_options: ${{ matrix.asan_options }} | ||
env: | ||
# Set pattern to not single_cpu if not already set | ||
PATTERN: ${{ env.PATTERN == '' && 'not single_cpu' || matrix.pattern }} | ||
|
||
- name: Test (single_cpu) | ||
uses: ./.github/actions/run-tests | ||
with: | ||
preload: ${{ matrix.preload }} | ||
asan_options: ${{ matrix.asan_options }} | ||
env: | ||
PATTERN: 'single_cpu' | ||
PYTEST_WORKERS: 0 | ||
|
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can remove this file too?