REF: Avoid importing xlrd

[rhshadrach]

• closes pandas.read_excel 'Can't determine version for xlrd' - old bug on pandas-2.1 #56692 (Replace xxxx with the GitHub issue number)
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Not sure how I'd add a test here.

[jbrockmendel]

Could check sys.modules for presence of xlrd?

[rhshadrach]

Could check sys.modules for presence of xlrd?

True; since that's global I think it'd have to check it in a subprocess. It seems to me a bit of an odd thing to test - unless we think we should have more testing that we don't import an optional dependency if it's not used more generally. Are we okay foregoing a test here?

[jbrockmendel]

Fine by me

…

On Mon, Mar 4, 2024 at 1:55 PM Richard Shadrach ***@***.***> wrote: Could check sys.modules for presence of xlrd? True; since that's global I think it'd have to check it in a subprocess. It seems to me a bit of an odd thing to test - unless we think we should have more testing that we don't import an optional dependency if it's not used more generally. Are we okay foregoing a test here? — Reply to this email directly, view it on GitHub <#57708 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5UM6HDBJRPX334VW46JMLYWTUTPAVCNFSM6AAAAABEDK5ATGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGUZDSMJXHE> . You are receiving this because you commented.Message ID: ***@***.***>

[mroeschke]

Thanks @rhshadrach