Skip to content

DEPR: Remove Index type checking attributes #57231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

mroeschke
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added the Index Related to the Index class or subclasses label Feb 3, 2024
@mroeschke mroeschke added this to the 3.0 milestone Feb 3, 2024
@mroeschke
Copy link
Member Author

Going to merge this one in. Happy to follow up.

@mroeschke mroeschke merged commit 5bc1e74 into pandas-dev:main Feb 8, 2024
@mroeschke mroeschke deleted the rm/idx_attrs branch February 8, 2024 22:09
@@ -104,15 +104,15 @@ Deprecations
Removal of prior version deprecations/changes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- All arguments except the first ``path``-like argument in IO writers are now keyword only (:issue:`54229`)
- Removed :meth:`DataFrame.first` and :meth:`DataFrame.last` (:issue:`53710`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this note deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I'll add it back in a follow up PR

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* DEPR: Remove Index type checking attributes

* Remove is_floating usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants