-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: Add note to user guide that SettingWithCopyWarning won't be necessary anymore #56032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
d7c2b55
8ea42c4
8cbac01
124cb9f
54240e5
3fa472b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -267,7 +267,15 @@ def read(self) -> DataFrame: | |
dtype_mapping[pa.null()] = pd.Int64Dtype() | ||
frame = table.to_pandas(types_mapper=dtype_mapping.get) | ||
elif using_pyarrow_string_dtype(): | ||
frame = table.to_pandas(types_mapper=arrow_string_types_mapper()) | ||
|
||
def types_mapper(dtype): | ||
dtype_dict = self.kwds["dtype"] | ||
if dtype_dict is not None and dtype_dict.get(dtype, None) is not None: | ||
return dtype_dict.get(dtype) | ||
return arrow_string_types_mapper()(dtype) | ||
|
||
frame = table.to_pandas(types_mapper=types_mapper) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accidental unrelated change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah not sure how that commit got in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reverted, sorry |
||
|
||
else: | ||
if isinstance(self.kwds.get("dtype"), dict): | ||
frame = table.to_pandas(types_mapper=self.kwds["dtype"].get) | ||
|
Uh oh!
There was an error while loading. Please reload this page.