Skip to content

Cython 3.0 faster maybe_convert_objects #55941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Nov 13, 2023

Since mask is a PyObject Cython 3.0 tries to do setting using the mapping protocol, which causes some slowdowns in tight loops.

This probably should have been cdef'ed to begin with anyway though

@mroeschke mroeschke added the Internals Related to non-user accessible pandas implementation label Nov 13, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 13, 2023
@mroeschke mroeschke merged commit 70ce4eb into pandas-dev:main Nov 13, 2023
@mroeschke
Copy link
Member

Thanks @WillAyd

@WillAyd WillAyd deleted the faster-maybe-convert-objects branch November 13, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants