Skip to content

BUG: Fix rounding of percentile 99.999% to 100% #55841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

parthi-siva
Copy link
Contributor

@parthi-siva parthi-siva commented Nov 6, 2023

- Round was introduced as a part of GH#48298
- But for 99.999 it is rounding to 100 causing GH#55765
- So added precision for rounding:
@parthi-siva parthi-siva changed the title Fix rounding of percentile 99.999% to 100% BUG: Fix rounding of percentile 99.999% to 100% Nov 6, 2023
@mroeschke mroeschke added the Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff label Nov 6, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 7, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a whatsnew note to v2.2.0.rst?

@parthi-siva
Copy link
Contributor Author

Could you add a whatsnew note to v2.2.0.rst?

Sure. Added

@@ -415,6 +415,7 @@ MultiIndex

I/O
^^^
- Bug in :func:`DataFrame.describe` when formatting percentiles in the resulting percentile 99.999% is rounded to 100% (:issue:`55765`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this in the Other section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done

@mroeschke mroeschke merged commit 7b32c17 into pandas-dev:main Nov 7, 2023
@mroeschke
Copy link
Member

Thanks @parthi-siva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: describe started rounding reported percentile 99.999% to 100%
2 participants