Skip to content

BUG: creating dataframe from masked numpy array turns missing string … #54787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

kshitiz305
Copy link

@kshitiz305 kshitiz305 commented Aug 28, 2023

…values into NaN

@kshitiz305
Copy link
Author

take

@mroeschke
Copy link
Member

Could you address the failing tests?

@kshitiz305 kshitiz305 requested a review from WillAyd as a code owner September 7, 2023 10:02
@kshitiz305
Copy link
Author

@jbrockmendel Hi I am facing some issue while testing the code with the following

# GH#18463 warnings.warn( f"Mismatched null-like values {a} and {b} found. In a future " "version, pandas equality-testing functions " "(e.g. assert_frame_equal) will consider these not-matching " "and raise.", FutureWarning, stacklevel=find_stack_level()

causing the test to fail while running

pytest pandas/tests/series/test_constructors.py

it has been 10 days but there has been no response on slack regarding the query. Kindly help

@@ -2,6 +2,7 @@ import cmath
import math
import warnings

warnings.simplefilter(action="ignore", category=FutureWarning)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not

@jbrockmendel
Copy link
Member

[...] causing the test to fail while running

pytest pandas/tests/series/test_constructors.py

That generally means you are doing something like tm.assert_series_equal(result, expected) and result/expected contain different NA-like values, e.g. one has np.nan while the other has None. To avoid the warning, they need to match.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 9, 2023
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: creating dataframe from masked numpy array turns missing string values into NaN
3 participants