Skip to content

DOC: Fixing EX01 - Added examples #54354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

@DeaMariaLeon DeaMariaLeon requested a review from mroeschke as a code owner August 1, 2023 15:15
@DeaMariaLeon DeaMariaLeon added this to the 2.1 milestone Aug 1, 2023
Comment on lines 143 to 146
Using deregister an error will be raised:

>>> pd.plotting.deregister_matplotlib_converters() # doctest: +SKIP
>>> df.plot.line(x='ts', y='y') # doctest: +SKIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it does, because df.plot automatically re-enables it

I think we can just use the same example from the other one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did it locally, but I can change it of course.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know, it plots fine for me

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have these lines on another cell and fails very nice :-)

pd.plotting.deregister_matplotlib_converters()
df.plot.line(x='ts', y='y') 

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. but don't worry I'll change it.

Copy link
Member

@MarcoGorelli MarcoGorelli Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 don't know then - are they the only two cells in the notebook? does it still fail if you only have those two and restart and run all?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soooooorry, there was a pd.set_option("plotting.matplotlib.deregister_converters", True) hidden making the trick.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DeaMariaLeon

@MarcoGorelli MarcoGorelli merged commit c93e803 into pandas-dev:main Aug 1, 2023
@DeaMariaLeon DeaMariaLeon deleted the deregister branch August 2, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants