Skip to content

DOC: point out the limitation of precision while doing serialization #54100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

DOC: point out the limitation of precision while doing serialization #54100

merged 1 commit into from
Jul 18, 2023

Conversation

natmokval
Copy link
Contributor

Updated docstring for to_json, pointed out that the maximal possible value for double_precision is equal 15.

@natmokval natmokval marked this pull request as ready for review July 13, 2023 05:51
@natmokval
Copy link
Contributor Author

Hi @phofl. I made a small documentation improvement: pointed out in to_json docstring, that the maximal possible value for the double_precision is 15. Could you please take a look at my pr?

@mroeschke mroeschke added Docs IO JSON read_json, to_json, json_normalize labels Jul 13, 2023
MarcoGorelli
MarcoGorelli approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval !

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jul 18, 2023
@MarcoGorelli MarcoGorelli merged commit ee18e06 into pandas-dev:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: to_json()/read_json() can't correctly dump/load numbers requiring >15 digits of precision
3 participants
@natmokval @MarcoGorelli @mroeschke