⬆️ UPGRADE: Autoupdate pre-commit config #54043
Conversation
mroeschke
requested review from
attack68,
rhshadrach,
MarcoGorelli and
WillAyd
as code owners
…e-commit-config-update-0
pyproject.toml
Outdated
| @@ -642,5 +646,5 @@ exclude_lines = [ | |||
| directory = "coverage_html_report" | |||
|
|
|||
| [tool.codespell] | |||
| ignore-words-list = "blocs, coo, hist, nd, sav, ser, recuse, nin, timere" | |||
| ignore-words-list = "blocs, coo, hist, nd, sav, ser, recuse, nin, timere, afile, foor, aas, mis" | |||
There was a problem hiding this comment.
Where are these new ignore words found?
Github code search doesn't seem to find them.
There was a problem hiding this comment.
These are found in the tests, either partially or fully in string variables
There was a problem hiding this comment.
Hm, might be good to add a comment or rename some of the variables.
There was a problem hiding this comment.
Sure thing. I'll just rename some variables
…e-commit-config-update-0
| @@ -1322,7 +1322,7 @@ def searchsorted( | |||
| arr: ArrayLike, | |||
| value: NumpyValueArrayLike | ExtensionArray, | |||
| side: Literal["left", "right"] = "left", | |||
| sorter: NumpySorter = None, | |||
| sorter: NumpySorter | None = None, | |||
| nmsp_dict = {"xmlns": n for p, n in self.namespaces.items() if p != ""} | ||
| nmsp_dict = { | ||
| "xmlns": n # noqa: RUF011 | ||
| for p, n in self.namespaces.items() | ||
| if p != "" | ||
| } |
There was a problem hiding this comment.
🤔 this does look a bit odd, but can be rewritten if necessary later
There was a problem hiding this comment.
Yeah agreed (@ParfaitG if you have any insight here)
There was a problem hiding this comment.
Because default namespaces have no prefixes, we allow users to pass a dictionary with empty string key. While etree uses the empty string for default namespaces ({'': URI_NAMESPACE}), lxml uses None for its key: {None : URI_NAMESPACE}.
However, looking at that code block though, it is repetitive where first if should format the prefix to key: f"xmlns:{p}". I can do a code cleanup later and add a test for more than two namespaces.
No description provided.