REF: move SparseDtype, ArrowDtype to dtypes.dtypes #53116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 9, 2023
| hash_array, | ||
| hash_pandas_object, | ||
| ) | ||
| def __getattr__(key: str): |
There was a problem hiding this comment.
Are these changes related to this PR?
|
Yes. Without this we raise at import time bc of circularity
…On Tue, May 9, 2023 at 10:45 AM Matthew Roeschke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/util/__init__.py
<#53116 (comment)>:
> @@ -1,11 +1,25 @@
-# pyright: reportUnusedImport = false
-from pandas.util._decorators import ( # noqa: F401
- Appender,
- Substitution,
- cache_readonly,
-)
-
-from pandas.core.util.hashing import ( # noqa: F401
- hash_array,
- hash_pandas_object,
-)
+def __getattr__(key: str):
Are these changes related to this PR?
—
Reply to this email directly, view it on GitHub
<#53116 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6B6EB6DE66CNDWQZBDXFJ7CVANCNFSM6AAAAAAXXVJH6M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mroeschke
approved these changes
May 15, 2023
|
Thanks @jbrockmendel |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* REF: move SparseDtype to dtypes.dtypes * REF: move ArrowDtype to dtypes.dtypes
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* REF: move SparseDtype to dtypes.dtypes * REF: move ArrowDtype to dtypes.dtypes
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* REF: move SparseDtype to dtypes.dtypes * REF: move ArrowDtype to dtypes.dtypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.