CLN: avoid upcasting in tests where unnecessary (PDEP-6 precursor) #53075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
May 4, 2023
Member
|
Thanks @MarcoGorelli |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
…andas-dev#53075) dont upcast when unnecessary Co-authored-by: MarcoGorelli <>
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…andas-dev#53075) dont upcast when unnecessary Co-authored-by: MarcoGorelli <>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…andas-dev#53075) dont upcast when unnecessary Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another precursor to PDEP6, similar to #52957
getting there...I think most of the remaining ones are when the test explicitly checks for upcasting behaviour, and so probably can't be changed right now