Skip to content

Using Literal["a"] instead of str in generic.py #52742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2023
Merged

Using Literal["a"] instead of str in generic.py #52742

merged 2 commits into from
Apr 20, 2023

Conversation

kevx82
Copy link
Contributor

@kevx82 kevx82 commented Apr 18, 2023 •
edited
Loading

Specifies limit_area in interpolate and how in asfreq more precisely.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@kevx82
fixes: specify limit_area in interpolate more precisely
cea5656 
an specify how in asfreq more precisely
@kevx82
Copy link
Contributor Author

kevx82 commented Apr 18, 2023

Worked on issue 10 for the following points:

  • Specify limit_area in interpolate more precisely
  • Specify how in asfreq more precisely

Please review the code: @phofl, @noatamir, @jorisvandenbossche, @MarcoGorelli

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
@kevx82 kevx82 changed the title fixes: specify limit_area in interpolate more precisely Using Literal["a"] instead of str in generic.py Apr 18, 2023
twoertwein
twoertwein approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can you please resolve the conflict?

phofl
phofl approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good to merge after conflicts are resolved.

@kevx82
Copy link
Contributor Author

kevx82 commented Apr 20, 2023

conflict resolved.

@phofl phofl added the Typing type annotations, mypy/pyright type checking label Apr 20, 2023
@phofl phofl added this to the 2.1 milestone Apr 20, 2023
@twoertwein twoertwein merged commit dd2f0d2 into pandas-dev:main Apr 20, 2023
@twoertwein
Copy link
Member

Thanks @kevx82 !

@kevx82 kevx82 deleted the ndframe-18-19 branch April 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kevx82 @twoertwein @phofl @noatamir