BUG/CLN: MI now checks level & label compatibility #5214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed it to validate pickles too. |
|
people okay with this? @wesm? |
|
good by me |
|
Performance impact probably minimal so this is fine to go in. |
|
Okay I'll rebase. I might add something to the docs about how setting levels or labels triggers a new round of validation. |
Via verify_integrity kwarg. Internals all pass False. CLN: Verify integrity by default on label/level setting
jtratner
added a commit
that referenced
this pull request
Oct 16, 2013
BUG/CLN: MI now checks level & label compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via verify_integrity kwarg. Internals all pass False.I don't think I've missed anything / passed verify_integrity=True where
it ought not to be.
Fixes #5213.
Clearly this adds a (likely small) perf hit - but should only occur
from external MI calls that specifically call the constructor with
levels and labels (for example, doesn't occur with
from_arraysorfrom_tuples). For 0.14 I'll have to do it differently, but this shouldwork for 0.13.