Skip to content

BUG: Fix NameError in tab complete warning test #51485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

smij720
Copy link
Contributor

@smij720 smij720 commented Feb 19, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

I was running the unit tests locally and noticed this:
image

From what I can tell, this is a problem with the test.

With this pull request, the test now passes without throwing this NameError:
image

@smij720 smij720 changed the title BUG - Fix NameError in tab complete warning test BUG: Fix NameError in tab complete warning test Feb 19, 2023
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, can’t reproduce locally. How did you run the tests?

@smij720
Copy link
Contributor Author

smij720 commented Feb 19, 2023

I run pytest pandas in the terminal:

image

I set up my environment using mamba following the instructions:
https://pandas.pydata.org/pandas-docs/stable/development/contributing_environment.html#option-1-using-mamba-recommended

@jbrockmendel
Copy link
Member

i regularly see this in my local test output

@phofl phofl added the Testing pandas testing functions or related to the test suite label Feb 19, 2023
@phofl phofl added this to the 2.0 milestone Feb 19, 2023
@phofl phofl merged commit 367d2a8 into pandas-dev:main Feb 19, 2023
@phofl
Copy link
Member

phofl commented Feb 19, 2023

thx @smij720

@smij720 smij720 deleted the fix-warnings-unit-test branch November 27, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants