Skip to content

DOC: fix EX02 errors in docstrings #51453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

natmokval
Copy link
Contributor

Related to the issue #51236

This PR enables functions:
pandas.core.groupby.DataFrameGroupBy.take
pandas.Timestamp.fromtimestamp

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval - looks like DataFrameGroupBy.take was already passing then?

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Feb 17, 2023
@natmokval
Copy link
Contributor Author

thanks @natmokval - looks like DataFrameGroupBy.take was already passing then?

It was fixed when I deleted pandas.core.groupby.SeriesGroupBy.take function from the ignore list in the previous PR #51432. It looks like the same changes in pandas/core/groupby/generic.py are required.

@MarcoGorelli MarcoGorelli merged commit 56dc877 into pandas-dev:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants