-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
PERF: ArrowExtensionArray.searchsorted #50447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f921559
PERF: ArrowExtensionArray.searchsorted
lukemanley 48c3830
gh ref
lukemanley ed45d75
fix
lukemanley c03c28a
Merge remote-tracking branch 'upstream/main' into arrow-ea-searchsorted
lukemanley 0ed5366
Merge remote-tracking branch 'upstream/main' into arrow-ea-searchsorted
lukemanley 43d5f45
add test for searchsorted when array contains pd.NA
lukemanley 0f93543
Merge remote-tracking branch 'upstream/main' into arrow-ea-searchsorted
lukemanley 504cc29
remove print statement
lukemanley f3e88fa
Merge remote-tracking branch 'upstream/main' into arrow-ea-searchsorted
lukemanley 09ecb16
Merge remote-tracking branch 'upstream/main' into arrow-ea-searchsorted
lukemanley 240031e
move tests
lukemanley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same error the base class would raise? Are there tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the base class raises:
The
ArrowExtensionArray.searchsorted
method added here is pretty much a copy ofBaseMaskedArray.searchsorted
. I will add a test. (I'll add one for BaseMaskedArray as well - I don't see it being tested there)