Skip to content

REF: share TimedeltaArray division code #50441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2022
Merged

REF: share TimedeltaArray division code #50441

merged 4 commits into from
Dec 28, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli self-requested a review December 26, 2022 21:38
@mroeschke mroeschke added Refactor Internal refactoring of code Timedelta Timedelta data type labels Dec 27, 2022
MarcoGorelli
MarcoGorelli approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Went through truediv, rtruediv, floordiv, and rfloordiv, and this looks legit

Looks like there's just a merge conflict to sort out

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 27, 2022
@mroeschke mroeschke merged commit b6eecb3 into pandas-dev:main Dec 28, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-td-div-share branch December 28, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Timedelta Timedelta data type
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @MarcoGorelli