BUG: #49889 #50098
Closed
BUG: #49889 #50098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Dec 7, 2022
| @@ -182,7 +182,7 @@ def categorical_column_to_series(col: Column) -> tuple[pd.Series, Any]: | |||
|
|
|||
| cat_column = categorical["categories"] | |||
| # for mypy/pyright | |||
| assert isinstance(cat_column, PandasColumn), "categories must be a PandasColumn" | |||
| assert isinstance(cat_column, Column), "categories must abide by __dataframe__ protocol API" | |||
There was a problem hiding this comment.
linter is failing here bc line is too long. try running black
|
I think the check for a dataframe interchange protocol |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: BUG: categorical_column_to_series() should not accept only PandasColumn #49889
Relaxed assert statement from
PandasColumntoColumnas not only Pandas column could be used here