Skip to content

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Nov 24, 2022

Summary of changes (separated out into separate commits for ease of review):

  • run pre-commit autoupdate, bumping a few versions
  • It's mostly using double-quotes in Cython files (cc @jbrockmendel 's suggestion in REF factor out parse_pydatetime from array_to_datetime #49866 (comment))
  • remove some unused variables / imports from pandas/_libs/parsers.pyx
  • rename variables named l, as that's a new flake8 check that disallows that, in:
    • pandas/tests/frame/indexing/test_getitem.py
    • pandas/tests/io/pytables/test_round_trip.py
    • pandas/tests/io/pytables/test_round_trip.py
  • move black to local hooks, because like this it runs twice (!) as fast, as they now compile with mypyc
  • add --verbose argument to CI job, so we can see how long each hook takes in CI
  • move yesqa to the manual stage (so it only runs in CI), as it's kind of slow and unnecessary most of the time (I don't think I've ever had a local commit fail because of it)

If reviewing, I'd suggest looked at each commit separately as they're each self-contained

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Nov 24, 2022
@MarcoGorelli MarcoGorelli marked this pull request as draft November 24, 2022 18:19
@MarcoGorelli MarcoGorelli changed the title STYLE pre-commit autoupdate STYLE pre-commit autoupdate, and other cleanups Nov 25, 2022
@MarcoGorelli MarcoGorelli marked this pull request as ready for review November 25, 2022 19:18
@MarcoGorelli MarcoGorelli force-pushed the pre-commit-autoupdate branch 3 times, most recently from b640a68 to 255804c Compare November 25, 2022 19:41
@mroeschke
Copy link
Member

IMO would be better if each commit is a pull request as it would be easier to revert a specific change if for some reason there was an issue with one particular change here

@MarcoGorelli
Copy link
Member Author

that's a fair point - I'll split it up then, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants