CLN: Cleanups in groupby due to numeric_only deprecations #49761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in groupby / resample
…/rhshadrach/pandas into enforce_groupby_numeric_only_none
rhshadrach
changed the title
rhshadrach
added
Groupby
Nuisance Columns
mroeschke
reviewed
Nov 18, 2022
…m/rhshadrach/pandas into enforce_groupby_numeric_only_none � Conflicts: � pandas/core/groupby/generic.py � pandas/core/groupby/groupby.py � pandas/tests/groupby/test_function.py � pandas/tests/groupby/test_groupby.py
…rce_groupby_numeric_only_none
…rce_groupby_numeric_only_none
mroeschke
approved these changes
Nov 22, 2022
|
Thanks @rhshadrach |
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
…#49761) * DEPR: Enforce deprecation of dropping columns when numeric_only=False in groupby / resample * Change to TypeError * Better error message * WIP * WIP * CLN: Cleanups in groupby due to numeric_only deprecations * revert * Remove ops from groupby.String * fixup * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Summary:
_op_via_apply, numeric_only being None or lib.no_default is the same as False since these just call the corresponding DataFrame methods where the deprecation has already been enforcedignore_failures=numeric_only is lib.no_default, across groupby numeric_only=lib.no_defualt is internally treated as numeric_only=True, so there is no reason to ignore failures.numeric_only=Truebut as this results in an empty frame the op instead defaults tonumeric_only=False. For the whatsnew, this will be covered by the general message that groupby will no longer automatically drop nuisance columns.