DEPR: Enforce deprecation of dropping columns when numeric_only=False in groupby / resample #49665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in groupby / resample
rhshadrach
added
Groupby
Resample
pandas/core/groupby/generic.py
Outdated
| arr_func, ignore_failures=numeric_only is lib.no_default | ||
| ) | ||
| except NotImplementedError as err: | ||
| msg = f"{how} is not supported for at least one provided dtype" |
There was a problem hiding this comment.
why not just let the original exception surface? wont that include dtype information?
There was a problem hiding this comment.
Thanks! That's much better.
mroeschke
approved these changes
Nov 16, 2022
|
Thanks @rhshadrach |
| arr_func, ignore_failures=numeric_only is lib.no_default | ||
| ) | ||
| except NotImplementedError as err: | ||
| # For NotImplementedError, args[0] is the error message |
There was a problem hiding this comment.
is this still the case if it was raised with just raise NotImplementedError?
There was a problem hiding this comment.
Ah - no, it's not. I'll fix in a followup. Thanks.
5 tasks
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Nov 17, 2022
… in groupby / resample (pandas-dev#49665) * DEPR: Enforce deprecation of dropping columns when numeric_only=False in groupby / resample * Change to TypeError * Better error message
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
… in groupby / resample (pandas-dev#49665) * DEPR: Enforce deprecation of dropping columns when numeric_only=False in groupby / resample * Change to TypeError * Better error message
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
… in groupby / resample (pandas-dev#49665) * DEPR: Enforce deprecation of dropping columns when numeric_only=False in groupby / resample * Change to TypeError * Better error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Prior to calling the cython code, cummin/cummax/cumsum/cumprod raise NotImplementedError on object dtypes. The Series path intercepts this and raises a TypeError instead. I've implemented the same here
except for DataFrame, we can't readily tell which dtype(s) would fail, so it raises a somewhat vague "at least one dtype" message.