DOC: Improve documented types for merge #48985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct list of supported types in docs Remove block creating incorrect docs in merge
mroeschke
reviewed
Oct 7, 2022
| @@ -220,10 +216,10 @@ def merge_ordered( | |||
| left_on docs. | |||
| left_by : column name or list of column names | |||
| Group left DataFrame by group columns and merge piece by piece with | |||
| right DataFrame. | |||
| right DataFrame. Must be None if either left or right are a Series. | |||
There was a problem hiding this comment.
I didn't immediately find tests raising if this was the case. Mind adding a unit test to confirm this behavior?
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
mroeschke
approved these changes
Dec 6, 2022
|
Thanks @bashtage if you could follow up with the unit test that would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct list of supported types in docs
Remove block creating incorrect docs in merge