CLN/DOC: Adjust xpath validation and error messaging in read_xml with IO tools doc note and example #48386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Sep 4, 2022
doc/source/user_guide/io.rst
Outdated
|
|
||
| shows the attribute sides on shape element was not parsed as expected | ||
| since this attribute resides on the child of row element and not row | ||
| element itself. In other words, sides attribute is a grandchild level |
There was a problem hiding this comment.
Suggested change
| element itself. In other words, sides attribute is a grandchild level | |
| element itself. In other words, the ``sides`` attribute is a grandchild level |
There was a problem hiding this comment.
Good to me. Will adjust.
gfyoung
reviewed
Sep 4, 2022
doc/source/user_guide/io.rst
Outdated
| df | ||
|
|
||
| shows the attribute sides on shape element was not parsed as expected | ||
| since this attribute resides on the child of row element and not row |
There was a problem hiding this comment.
Suggested change
| since this attribute resides on the child of row element and not row | |
| since this attribute resides on the child of a row element and not the row |
There was a problem hiding this comment.
Articles are not needed here since note is specifically referring to element in XML which is literally named <row>.
There was a problem hiding this comment.
I see. Then put double backticks instead.
gfyoung
approved these changes
Sep 5, 2022
mroeschke
approved these changes
Sep 6, 2022
|
Thanks @ParfaitG |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
… IO tools doc note and example (pandas-dev#48386) * CLN/DOC: Adjust xpath validation and error messaging in read_xml with IO tools doc note and example * Fix xpath validation for child elements with added test * Adjust IO tools docs for backticks on XML names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.