Fix stacklevel dayfirst warning #47908
Conversation
pandas/_testing/_warnings.py
Outdated
| @@ -130,7 +130,8 @@ def _assert_caught_expected_warning( | |||
| saw_warning = True | |||
|
|
|||
| if check_stacklevel and issubclass( | |||
| actual_warning.category, (FutureWarning, DeprecationWarning) | |||
| actual_warning.category, | |||
| (FutureWarning, DeprecationWarning, UserWarning), | |||
There was a problem hiding this comment.
the test which checked the warning passes on main because stacklevel is only checked for FutureWarning and DeprecationWarning
| @@ -63,6 +63,7 @@ from pandas._libs.tslibs.util cimport ( | |||
| get_c_string_buf_and_size, | |||
| is_array, | |||
| ) | |||
| from pandas.util._exceptions import find_stack_level | |||
There was a problem hiding this comment.
@jbrockmendel any suggestions on how to do this without importing from outisde _libs (as you'd previously requested on a different PR)?
There was a problem hiding this comment.
you could import it when u need this (eg near usage)
or move the implementation to _libs itself
There was a problem hiding this comment.
I think this is a case where the rule-of-thumb preventing non-_libs imports is OK to break
MarcoGorelli
force-pushed
the
fix-stacklevel-dayfirst-warning
branch
from
f135ba3 to
4cf3d9b
Compare
|
OK thanks, I've stuck with the original import then I've made a separate issue about catching this incorrect stacklevel in tests, will address that separately if that's OK #47919 |
|
closing as I'm taking this forwards in #47998 |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.