Skip to content

CLN: Rename "add" to "sum" in groupby #47892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Jul 29, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

sum is the one method whose name doesn't agree with the corresponding how

@rhshadrach rhshadrach changed the title CLN: Rename "add" to "sum" CLN: Rename "add" to "sum" in groupby Jul 29, 2022
@attack68
Copy link
Contributor

When looking at this it reminded me of Pokemon: 'are you sure you caught them all?'

@mroeschke mroeschke added this to the 1.5 milestone Jul 29, 2022
@rhshadrach
Copy link
Member Author

@attack68 - I think our test coverage is sufficient to feel good I got all the code changes. For comments, I would guess it's possible I missed some. I used grep -nr --include \*.p* "add" in both the groupby and the _libs directories and went through the results (and just double checked now).

@mroeschke mroeschke merged commit 0b6d120 into pandas-dev:main Jul 29, 2022
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the rename_add branch July 29, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants