BUG: Fix wrong str.format() calls in Index.summary #4751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rember this one! thxs |
|
@jreback look okay? |
ghost
assigned 
| head = head.format() | ||
| tail = self[-1] | ||
| if hasattr(tail,'format'): |
There was a problem hiding this comment.
should this be: not isinstance(tail ... ?
There was a problem hiding this comment.
yes. blah...not on a roll today.
There was a problem hiding this comment.
and I'll change the test case too so it fails if it doesn't check that.
There was a problem hiding this comment.
actually...not so useful to test both of those cases independently...not sure it's important to add more cases...what do you think?
There was a problem hiding this comment.
not a big deal this is a bizarre edge case anyhow
There was a problem hiding this comment.
great. then this is done.
|
otherwise ok |
jtratner
added a commit
that referenced
this pull request
Sep 5, 2013
BUG: Fix wrong str.format() calls in Index.summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3869.