BUG: iterparse of read_xml not parsing duplicate element and attribute names #47414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jun 18, 2022
| row[col] = elem.text.strip() if elem.text else None | ||
| if col in elem.attrib: | ||
| row[col] = elem.attrib[col] | ||
| if self.names: |
There was a problem hiding this comment.
Good point. I refactored to use code once in base class of the parsers.
There was a problem hiding this comment.
This is a bit confusing now. Could you split the refactoring and the bug fix into 2 prs? Hard to review like this
There was a problem hiding this comment.
Will revert back to bug fix only and on subsequent PR refactor to remove repetitive code between parsers.
There was a problem hiding this comment.
Thanks.
I was not sure if you could share more initially, but if you can share most of the code than we can separate these
phofl
approved these changes
Jun 20, 2022
mroeschke
reviewed
Jun 21, 2022
mroeschke
approved these changes
Jun 21, 2022
|
Thanks @ParfaitG |
3 tasks
5 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…e names (pandas-dev#47414) * BUG: iterparse of read_xml not parsing duplicate element and attribute names * Refactor duplicative code in each parser to shared base class * Add lxml preceding-sibling iterparse cleanup * Revert code refactoring back to bug fix only * Remove whatsnew bug fix note on unreleased version feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.