TYP: plotting._matplotlib #47311
Merged
TYP: plotting._matplotlib #47311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Jun 11, 2022
twoertwein
commented
Jun 11, 2022
| @@ -574,6 +574,8 @@ def _daily_finder(vmin, vmax, freq: BaseOffset): | |||
| Period(ordinal=int(vmin), freq=freq), | |||
| Period(ordinal=int(vmax), freq=freq), | |||
| ) | |||
| assert isinstance(vmin, Period) | |||
| assert isinstance(vmax, Period) | |||
| span = vmax.ordinal - vmin.ordinal + 1 | |||
There was a problem hiding this comment.
Can safely assert as NaT has no attribute called ordinal
twoertwein
commented
Jun 11, 2022
| return Period(ordinal=int(x), freq=self.freq).strftime(fmt) | ||
| period = Period(ordinal=int(x), freq=self.freq) | ||
| assert isinstance(period, Period) | ||
| return period.strftime(fmt) |
There was a problem hiding this comment.
same here: NaT has no strftime
twoertwein
commented
Jun 11, 2022
| return Period(x[0], freq_str).to_timestamp().tz_localize(x.tz) == x[0] | ||
| period = Period(x[0], freq_str) | ||
| assert isinstance(period, Period) | ||
| return period.to_timestamp().tz_localize(x.tz) == x[0] |
There was a problem hiding this comment.
NaT has no to_timestamp
twoertwein
commented
Jun 11, 2022
| return "vertical" | ||
|
|
||
| @property | ||
| def _kind(self) -> Literal["line", "area", "hist", "kde", "box"]: |
There was a problem hiding this comment.
Needed so that the sub-classes are compatible with LinePlot
mroeschke
reviewed
Jun 13, 2022
| @@ -185,11 +185,10 @@ def _get_ax_freq(ax: Axes): | |||
| return ax_freq | |||
|
|
|||
|
|
|||
| def _get_period_alias(freq) -> str | None: | |||
| def _get_period_alias(freq: BaseOffset | str) -> str | None: | |||
There was a problem hiding this comment.
The pyi is typed as timedelta | BaseOffset | str and the docstring says to_offset takes timedeltas as well. Should that be included here?
There was a problem hiding this comment.
Thanks, yes timedelta should be allowed.
mroeschke
approved these changes
Jun 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: plotting._matplotlib * somehow super causes issues * fix pickle issue: was accessing _kind on class * and the last plotting file * add timedelta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two main changes are 1) consistently using
propertyand 2) checking whetherPeriod()returnsNaT.