Changes as requested in #47058 #47119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first open-source contribution. Please let me know if there are any mistakes, will rectify them
|
Hello @MaruthiKo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-25 20:37:42 UTC |
mroeschke
reviewed
May 25, 2022
mroeschke
reviewed
May 25, 2022
Please let me know if have to change anything.
If any more changes required please let me know.
mroeschke
reviewed
May 25, 2022
Let me know if there are any changes
mroeschke
reviewed
May 25, 2022
mroeschke
reviewed
May 25, 2022
mroeschke
reviewed
May 25, 2022
mroeschke
approved these changes
May 25, 2022
|
Awesome thanks @MaruthiKo and welcome to pandas & open source! |
Thank you so much, it would not be possible without your help! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* Changes as requested in pandas-dev#47058 This is my first open-source contribution. Please let me know if there are any mistakes, will rectify them * required changes as per pandas-dev#47058 Please let me know if have to change anything. * changes to doc as per pandas-dev#47058 If any more changes required please let me know. * Changes to doc as per pandas-dev#47058 Let me know if there are any changes * Update pandas/core/generic.py * Update pandas/core/generic.py * Update pandas/core/generic.py Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first open-source contribution. Please let me know if there are any mistakes, will rectify them
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.