-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Fix NaN bug in ujson #46628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NaN bug in ujson #46628
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -417,6 +417,9 @@ def test_encode_time_conversion_dateutil(self): | |
def test_encode_as_null(self, decoded_input): | ||
assert ujson.encode(decoded_input) == "null", "Expected null" | ||
|
||
def test_decode_nan(self, decoded_input): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you create a test in one of the other modules in this same directory? I think this module was copied directly from ujson but is detached from what an end user would see, as no end user really imports ujson through pandas. Would be a better test if we can re-create how an end user would come to this through one of the pandas objects There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added a test in pandas.tests.io.json.test_pandas that uses the MWE from the bug report. I think this test should stay here as well, as a similar test now exists in ujson itself. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternatively, we could consider "re-vendoring" ujson now that this bug is fixed in it's main branch as well. But I'm not sure if pandas has other modifications or not (and if their are, they probably should be backported anyway). |
||
assert math.isnan(ujson.dumps("[NaN]")[0]) | ||
|
||
def test_datetime_units(self): | ||
val = datetime.datetime(2013, 8, 17, 21, 17, 12, 215504) | ||
stamp = Timestamp(val) | ||
|
Uh oh!
There was an error while loading. Please reload this page.