Test case dataframe.groupby incorrect with multiindex and None value #45982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikhor
changed the title
phofl
reviewed
Feb 14, 2022
| ) | ||
| grps = df.groupby(by=["A", "B"]) | ||
|
|
||
| with pytest.raises(KeyError): |
There was a problem hiding this comment.
Can you add a match statement? I think pre-commit is complaining about this too
There was a problem hiding this comment.
Please let the reviewer mark conversations as resolved
I mean:
pytest.raises(KeyError, match="String to match"):
added 2 commits
February 15, 2022 00:41
phofl
reviewed
Feb 15, 2022
| ) | ||
| grps = df.groupby(by=["A", "B"]) | ||
|
|
||
| with pytest.raises(KeyError, match="Selecting group which is not exist"): |
There was a problem hiding this comment.
Please run your test locally before pushing, it is failing.
phofl
reviewed
Feb 15, 2022
| @@ -314,3 +314,18 @@ def test_groupby_duplicated_columns(func): | |||
| [[1.5, 3.0, 1.5]], columns=["A", "B", "A"], index=pd.Index(["G"], name="C") | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_dataframe_groupby_incorrect_with_multiindex_make_df_from_data(): | |||
There was a problem hiding this comment.
Could you give a better name? Something like test_groupby_get_nonexisting_groups
added 2 commits
February 15, 2022 19:59
jreback
added
Groupby
MultiIndex
Testing
|
lgtm @phofl merge when ready |
phofl
approved these changes
Feb 16, 2022
|
Thanks @weikhor |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…andas-dev#45982) * Add test * Update test_indexing.py * Update test_indexing.py * Update pytest.raises * add match * change function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.