Skip to content

TST: Use pytest idioms in test_libsparse #45975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Feb 13, 2022
@mroeschke mroeschke added this to the 1.5 milestone Feb 13, 2022
],
)
def test_index_make_union(self, xloc, xlen, yloc, ylen, eloc, elen):
# Case 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick might make sense for this comment to be split into pieces between the cases L94-L101?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for follow-up, this is a big improvement as is

@mroeschke mroeschke merged commit a7a5b0b into pandas-dev:main Feb 14, 2022
@mroeschke mroeschke deleted the tst/libsparse_param branch February 14, 2022 17:32
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* TST: Use pytest idioms in test_libsparse

* Ignore typing in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants