TST: Use pytest idioms in test_libsparse #45975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Feb 13, 2022
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
the
Testing
| ], | ||
| ) | ||
| def test_index_make_union(self, xloc, xlen, yloc, ylen, eloc, elen): | ||
| # Case 1 |
There was a problem hiding this comment.
nitpick might make sense for this comment to be split into pieces between the cases L94-L101?
There was a problem hiding this comment.
OK for follow-up, this is a big improvement as is
jbrockmendel
approved these changes
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TST: Use pytest idioms in test_libsparse * Ignore typing in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.