Bug fix - Astype Timedelta64[ns] fails when np.nan is included #45965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/dtypes/astype.py
Outdated
| @@ -134,7 +134,8 @@ def astype_nansafe( | |||
| raise TypeError(f"cannot astype a timedelta from [{arr.dtype}] to [{dtype}]") | |||
|
|
|||
| elif np.issubdtype(arr.dtype, np.floating) and np.issubdtype(dtype, np.integer): | |||
There was a problem hiding this comment.
i think use is_integer_dtype(dtype) instead of issubdtype would be simpler
jreback
requested changes
Feb 16, 2022
| @@ -482,3 +482,10 @@ def test_getitem_str_second_with_datetimeindex(): | |||
| msg = r"Timestamp\('2012-01-02 18:01:02-0600', tz='US/Central', freq='S'\)" | |||
| with pytest.raises(KeyError, match=msg): | |||
| df[df.index[2]] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
these are astype tests, pls move them.
| def test_astype_timedelta64_with_np_nan(): | ||
| # GH45798 | ||
| result = Series([1, np.nan]).astype("timedelta64[ns]") | ||
| expected = Series([1, pd.NaT]).astype("timedelta64[ns]") |
There was a problem hiding this comment.
to be explictily construct here the expected
There was a problem hiding this comment.
Hi I do not understand. Can please give more details? Thank.
There was a problem hiding this comment.
if the method being tested is Series.astype, then the test belongs in tests.series.methods.test_astype
jreback
added
Dtype Conversions
jreback
requested changes
Feb 27, 2022
added 3 commits
February 27, 2022 13:58
…timedelta64_with_np_nan
weikhor
changed the title
|
@jreback @jbrockmendel |
jreback
approved these changes
Feb 27, 2022
|
thanks @weikhor |
| @@ -284,7 +284,7 @@ Datetimelike | |||
|
|
|||
| Timedelta | |||
| ^^^^^^^^^ | |||
| - | |||
| - Bug in :func:`astype_nansafe` astype("timedelta64[ns]") fails when np.nan is included (:issue:`45798`) | |||
There was a problem hiding this comment.
is there a user-facing method we can refer to?
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astype("timedelta64[ns]")fails whennp.nanis included #45798doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.