Skip to content

CI/TST: Skip external s3 bucket test that hangs on min build #45665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2022
Merged

CI/TST: Skip external s3 bucket test that hangs on min build #45665

merged 4 commits into from
Jan 28, 2022

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added the CI Continuous Integration label Jan 27, 2022
@mroeschke mroeschke marked this pull request as draft January 27, 2022 22:22
@mroeschke
Copy link
Member Author

Looks like one of the processes got stuck on test_s3_parser_consistency

2022-01-27T23:11:31.0333115Z [gw1] PASSED pandas/tests/io/xml/test_xml.py::test_unsuported_compression[etree] 
2022-01-27T23:11:35.6861543Z pandas/tests/io/xml/test_xml.py::test_s3_parser_consistency 
2022-01-27T23:11:35.6944349Z [gw0] PASSED pandas/tests/io/sas/test_sas7bdat.py::TestSAS7BDAT::test_iterator_loop

In 1fd4e92, I don't see that test ever complete in the logs.

@mroeschke mroeschke changed the title Debug/CI: Min build CI: Skip external s3 bucket test that hangs on min build Jan 28, 2022
@mroeschke mroeschke marked this pull request as ready for review January 28, 2022 03:34
@mroeschke
Copy link
Member Author

@jbrockmendel min build is green here. Wdyt?

jbrockmendel
jbrockmendel reviewed Jan 28, 2022
View reviewed changes
pandas/tests/io/xml/test_xml.py
@pytest.mark.skipif(
os.environ.get("PANDAS_CI", "0") == "1",
reason="2022.1.17: Hanging on the CI min versions build.",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re confident this is the culprit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly. I'll run one more time removing the -v

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

jbrockmendel
jbrockmendel reviewed Jan 28, 2022
View reviewed changes
@mroeschke mroeschke changed the title CI: Skip external s3 bucket test that hangs on min build CI/TST: Skip external s3 bucket test that hangs on min build Jan 28, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jan 28, 2022
@mroeschke mroeschke added IO Network Local or Cloud (AWS, GCS, etc.) IO Issues Testing pandas testing functions or related to the test suite labels Jan 28, 2022
@mroeschke
Copy link
Member Author

All green on the min build. Going to merge.

@mroeschke mroeschke merged commit 4e30caa into pandas-dev:main Jan 28, 2022
@mroeschke mroeschke deleted the debug/min_build branch January 28, 2022 06:41
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@mroeschke @phofl
CI/TST: Skip external s3 bucket test that hangs on min build (pandas-…
403f78c 
…dev#45665)

* Debug/CI: Min build

* Skip the s3 tests

* Remove -v
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
CI/TST: Skip external s3 bucket test that hangs on min build (pandas-…
9274985 
…dev#45665)

* Debug/CI: Min build

* Skip the s3 tests

* Remove -v
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jbrockmendel