BUG: raise on wrong keyword arguments in Timedelta #45227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deponovo
commented
Jan 6, 2022
deponovo
commented
- closes BUG: Fix nanosecond timedeltas #45108
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
TST: added respective testing
jbrockmendel
reviewed
Jan 6, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -121,7 +121,7 @@ Datetimelike | |||
|
|
|||
| Timedelta | |||
| ^^^^^^^^^ | |||
| - | |||
| - Now raising on missing or invalid kwargs (:issue:`43764`) | |||
There was a problem hiding this comment.
Since this is a regression in 1.4, im pretty sure this note goes in 1.4.1, can double-check with @simonjayhawkins
There was a problem hiding this comment.
actually move to 1.4 as we haven't released yet
|
couple of linting failures in the Code Checks job |
jreback
requested changes
Jan 8, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -121,7 +121,7 @@ Datetimelike | |||
|
|
|||
| Timedelta | |||
| ^^^^^^^^^ | |||
| - | |||
| - Now raising on missing or invalid kwargs (:issue:`43764`) | |||
There was a problem hiding this comment.
actually move to 1.4 as we haven't released yet
jreback
reviewed
Jan 8, 2022
jreback
reviewed
Jan 8, 2022
|
thanks @deponovo |
This comment has been minimized.
This comment has been minimized.
|
@meeseeksdev backport 1.4.x |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jan 10, 2022
jreback
pushed a commit
that referenced
this pull request
Jan 10, 2022
#45295) Co-authored-by: deponovo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.