Skip to content

BUG: fix GH45032 iloc(axis=1).__setitem__ axis argument #45150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 3, 2022
Merged

BUG: fix GH45032 iloc(axis=1).__setitem__ axis argument #45150

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
de85a1e
GH45032 fix iloc._get_setitem_indexer
ellequelle Dec 31, 2021
d0803dd
test for GH45032
ellequelle Dec 31, 2021
d0ed9dc
Merge branch 'master' into pandas-elle
ellequelle Dec 31, 2021
2bc9256
update what's new
ellequelle Dec 31, 2021
ed058d2
reoganize tests for GH45032 & remove comment
ellequelle Jan 1, 2022
9780362
Merge branch 'pandas-elle' of https://github.com/ellequelle/pandas in…
ellequelle Jan 1, 2022
2572ad6
Merge branch 'master' into pandas-elle
ellequelle Jan 1, 2022
1aced57
Merge branch 'master' into pandas-elle
ellequelle Jan 1, 2022
ab8b2aa
pre-commit changes
ellequelle Jan 1, 2022
d9a7ff8
Merge branch 'master' into pandas-elle
ellequelle Jan 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v1.4.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,8 @@ Indexing
- Fixed regression where a single column ``np.matrix`` was no longer coerced to a 1d ``np.ndarray`` when added to a :class:`DataFrame` (:issue:`42376`)
- Bug in :meth:`Series.__getitem__` with a :class:`CategoricalIndex` of integers treating lists of integers as positional indexers, inconsistent with the behavior with a single scalar integer (:issue:`15470`, :issue:`14865`)
- Bug in :meth:`Series.__setitem__` when setting floats or integers into integer-dtype series failing to upcast when necessary to retain precision (:issue:`45121`)
-
- Bug in :meth:`DataFrame.iloc.__setitem__` ignores axis argument (:issue:`45032`)
-

Missing
^^^^^^^
Expand Down
7 changes: 6 additions & 1 deletion pandas/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,7 +1540,12 @@ def _convert_to_indexer(self, key, axis: int):
def _get_setitem_indexer(self, key):
# GH#32257 Fall through to let numpy do validation
if is_iterator(key):
return list(key)
key = list(key)

# GH#45032 handle iloc(axis=1)
if self.axis is not None:
return self._convert_tuple(key)

return key

# -------------------------------------------------------------------
Expand Down
13 changes: 13 additions & 0 deletions pandas/tests/indexing/test_iloc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,19 @@ def test_iloc_setitem(self):
expected = Series([0, 1, 0], index=[4, 5, 6])
tm.assert_series_equal(s, expected)

def test_iloc_setitem_axis_argument(self):
# GH45032
dfa = DataFrame([[6, "c", 10], [7, "d", 11], [8, "e", 12]])
dfb = DataFrame([[6, "c", 10], [7, "d", 11], [8, "e", 12]])
expected_a = DataFrame([[6, "c", 10], [7, "d", 11], [5, 5, 5]])
expected_b = DataFrame([[6, "c", 5], [7, "d", 5], [8, "e", 5]])

dfa.iloc(axis=0)[2] = 5
tm.assert_frame_equal(dfa, expected_a)

dfb.iloc(axis=1)[2] = 5
tm.assert_frame_equal(dfb, expected_b)

def test_iloc_setitem_list(self):

# setitem with an iloc list
Expand Down